fix: allow stable mcp source ids

src/wf_sources_mcp/connections.py

@@ -46,15 +46,11 @@ class McpSourceConnection:
     metadata: dict[str, object] = field(default_factory=dict)
 
     def __post_init__(self) -> None:
-        provider, account = parse_connection_id(self.id)
+        parse_connection_id(self.id)
         if not self.provider:
             raise ValueError("provider must not be empty")
         if not self.account:
             raise ValueError("account must not be empty")
-        if provider != self.provider or account != self.account:
-            raise ValueError(
-                "MCP source connection id must match provider/account fields"
-            )
 
     @property
     def server(self) -> str:

tests/wf_sources_mcp/test_connections.py

@@ -48,7 +48,9 @@ def test_stdio_source_transport_is_typed() -> None:
 
 
 def test_http_source_transport_is_typed() -> None:
-    transport = HttpSourceTransport(url="http://127.0.0.1:8000/mcp")
+    transport = HttpSourceTransport.model_validate(
+        {"url": "http://127.0.0.1:8000/mcp"}
+    )
 
     assert transport.kind == "http"
     assert str(transport.url) == "http://127.0.0.1:8000/mcp"
@@ -156,6 +158,23 @@ def test_mcp_source_connection_from_legacy_connection_config_stdio() -> None:
     assert connection.transport.cwd == "C:/repo"
 
 
+def test_mcp_source_connection_allows_stable_id_distinct_from_account() -> None:
+    """Config source ids are stable keys; provider/account describe upstream identity."""
+
+    legacy = _LegacyConnectionLike(
+        id="everything.default",
+        server="everything",
+        account="demo",
+        metadata={"transport": "stdio", "command": "npx"},
+    )
+
+    connection = mcp_source_connection_from_connection_config(legacy)
+
+    assert connection.id == "everything.default"
+    assert connection.provider == "everything"
+    assert connection.account == "demo"
+
+
 def test_mcp_source_connection_from_legacy_connection_config_http() -> None:
     from wf_mcp.broker.models import ConnectionConfig