lda.chat/lda-wf
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: contain lifecycle chat on wide stages

Browse Source
This commit is contained in:
lda
2026-07-13 18:15:19 +07:00 Verified
parent 129969e829
commit 649844d28f
2 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/apps/console/src/presentation/presentation-css.test.ts
+14 -5
View File
@@ -102,6 +102,10 @@ describe("presentation.css", () => {
it("keeps the discussion row in the presentation column and stacks it before chat on mobile", () => { it("keeps the discussion row in the presentation column and stacks it before chat on mobile", () => {
const discussion = cssBlocks(css, ".prepared-lifecycle-scene__discussion") const discussion = cssBlocks(css, ".prepared-lifecycle-scene__discussion")
.find((body) => body.includes("grid-area: discussion;")); .find((body) => body.includes("grid-area: discussion;"));
const discussionRail = cssBlocks(
css,
".prepared-lifecycle-scene__discussion > .scene-body__discussion-links",
).find((body) => body.includes("border-top: 0;"));
const assistant = cssBlocks(css, ".prepared-lifecycle-scene > .presentation-assistant-pane") const assistant = cssBlocks(css, ".prepared-lifecycle-scene > .presentation-assistant-pane")
.find((body) => body.includes("grid-area: assistant;")); .find((body) => body.includes("grid-area: assistant;"));
const presentation = cssBlocks(css, ".prepared-lifecycle-scene__presentation") const presentation = cssBlocks(css, ".prepared-lifecycle-scene__presentation")
@@ -111,8 +115,12 @@ describe("presentation.css", () => {
.find((body) => body.includes('grid-template-areas: "presentation" "discussion" "assistant";')); .find((body) => body.includes('grid-template-areas: "presentation" "discussion" "assistant";'));
expect(discussion).toContain("grid-area: discussion;"); expect(discussion).toContain("grid-area: discussion;");
expect(discussion).not.toContain("background:"); expect(discussion).toContain("margin: 0;");
expect(discussion).not.toContain("border:"); expect(discussion).toContain("border: 0;");
expect(discussion).toContain("padding: 0;");
expect(discussion).toContain("background: transparent;");
expect(discussionRail).toContain("border-top: 0;");
expect(discussionRail).toContain("background: transparent;");
expect(assistant).toContain("grid-area: assistant;"); expect(assistant).toContain("grid-area: assistant;");
expect(presentation).toContain("grid-area: presentation;"); expect(presentation).toContain("grid-area: presentation;");
expect(narrowScene).toContain('grid-template-areas: "presentation" "discussion" "assistant";'); expect(narrowScene).toContain('grid-template-areas: "presentation" "discussion" "assistant";');
@@ -241,8 +249,6 @@ describe("presentation.css", () => {
it("keeps wide lifecycle evidence compact instead of stretching into a sparse frame", () => { it("keeps wide lifecycle evidence compact instead of stretching into a sparse frame", () => {
const wideContainer = cssBlock(css, "@container presentation-canvas (min-width: 1500px)") ?? ""; const wideContainer = cssBlock(css, "@container presentation-canvas (min-width: 1500px)") ?? "";
const wideScene = cssBlocks(wideContainer, '.prepared-lifecycle-scene[data-presentation-surface="editorial"]')
.find((body) => body.includes("grid-template-rows: max-content auto;"));
const widePresentation = cssBlocks( const widePresentation = cssBlocks(
wideContainer, wideContainer,
'.prepared-lifecycle-scene[data-presentation-surface="editorial"] .prepared-lifecycle-scene__presentation', '.prepared-lifecycle-scene[data-presentation-surface="editorial"] .prepared-lifecycle-scene__presentation',
@@ -252,7 +258,10 @@ describe("presentation.css", () => {
'.prepared-lifecycle-scene[data-presentation-surface="editorial"] .prepared-lifecycle-scene__frame', '.prepared-lifecycle-scene[data-presentation-surface="editorial"] .prepared-lifecycle-scene__frame',
).find((body) => body.includes("height: max-content;")); ).find((body) => body.includes("height: max-content;"));
expect(wideScene).toContain("align-content: start;"); // The scene itself must retain its bounded rows so the chat pane cannot size from its transcript.
expect(wideContainer).not.toMatch(
/\.prepared-lifecycle-scene\[data-presentation-surface="editorial"\]\s*\{/,
);
expect(widePresentation).toContain("align-content: start;"); expect(widePresentation).toContain("align-content: start;");
expect(wideFrame).toContain("max-height: min(34rem, 56vh);"); expect(wideFrame).toContain("max-height: min(34rem, 56vh);");
expect(wideFrame).toContain("overflow: visible;"); expect(wideFrame).toContain("overflow: visible;");
web/apps/console/src/presentation/presentation.css
+7 -5
View File
@@ -3480,11 +3480,18 @@
grid-area: discussion; grid-area: discussion;
min-width: 0; min-width: 0;
min-height: 0; min-height: 0;
margin: 0;
border: 0;
border-radius: 0;
padding: 0;
background: transparent;
} }
.prepared-lifecycle-scene__discussion > .scene-body__discussion-links { .prepared-lifecycle-scene__discussion > .scene-body__discussion-links {
margin-top: 0; margin-top: 0;
border-top: 0;
padding-top: 0.3rem; padding-top: 0.3rem;
background: transparent;
} }
.prepared-lifecycle-scene__rail { .prepared-lifecycle-scene__rail {
@@ -4015,11 +4022,6 @@
/* Keep the wide stage editorial instead of turning the phase frame into a blank wall. */ /* Keep the wide stage editorial instead of turning the phase frame into a blank wall. */
@container presentation-canvas (min-width: 1500px) { @container presentation-canvas (min-width: 1500px) {
.prepared-lifecycle-scene[data-presentation-surface="editorial"] {
grid-template-rows: max-content auto;
align-content: start;
}
.prepared-lifecycle-scene[data-presentation-surface="editorial"] .prepared-lifecycle-scene__presentation { .prepared-lifecycle-scene[data-presentation-surface="editorial"] .prepared-lifecycle-scene__presentation {
grid-template-rows: auto max-content; grid-template-rows: auto max-content;
align-content: start; align-content: start;