fix: bound recursive authoring schema traversal

2026-08-14 14:42:58 +07:00
parent dc4682992b
commit 696a45c3c0
3 changed files with 77 additions and 0 deletions
@@ -58,3 +58,36 @@ uv run ruff format --check src/wf_api/authoring_contracts.py src/wf_api/models/a

 None for the Task 1 scope. Runtime-context analysis and persisted workspace or
 capability loading remain intentionally deferred to Tasks 2 and 3.
+
+## Round 1 Fix
+
+The review identified that recursive schema walking was not bounded even
+though individual `$ref` chains were bounded. A self-referential local
+definition repeatedly expanded `_append_schema_options` until
+`RecursionError`.
+
+Added the regression test
+`test_schema_path_options_stops_expanding_recursive_local_definition` before
+changing production code. The RED run failed with `RecursionError` in
+`_append_schema_options` after repeatedly traversing the self-reference.
+
+The fix tracks active local `$ref` definitions per traversal branch. A repeated
+definition is emitted as a selectable path but is not expanded again. Distinct
+active references are also capped using the existing
+`_MAX_LOCAL_SCHEMA_REFERENCE_DEPTH` limit from `schema_projection`.
+
+Round 1 verification:
+
+```text
+uv run pytest tests/wf_api/test_authoring_contracts.py tests/wf_api/test_schema_projection.py -q
+49 passed
+
+uv run basedpyright --level error src/wf_api/authoring_contracts.py src/wf_api/models/authoring_contracts.py
+0 errors, 0 warnings, 0 notes
+
+uv run ruff check src/wf_api/authoring_contracts.py src/wf_api/models/authoring_contracts.py src/wf_api/models/__init__.py tests/wf_api/test_authoring_contracts.py
+All checks passed!
+
+uv run ruff format --check src/wf_api/authoring_contracts.py src/wf_api/models/authoring_contracts.py src/wf_api/models/__init__.py tests/wf_api/test_authoring_contracts.py
+4 files already formatted
+```