fix: prevent authoring evidence clipping
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { useLayoutEffect, useReducer, useRef } from "react";
|
||||
import { useReducer } from "react";
|
||||
import { projectPreparedAuthoringPhase } from "./authoring-projection.js";
|
||||
import { AuthoringPhaseVisual } from "./AuthoringPhaseVisual.js";
|
||||
import { PresentationAssistantPane } from "./PresentationAssistantPane.js";
|
||||
@@ -41,16 +41,6 @@ export const PreparedAuthoringLifecycleScene = ({ scene, beat, onAdvance }: Prep
|
||||
// if a future beat reaches this scene before its authoring mapping is added.
|
||||
const beatId = phases.find((phase) => phase.id === beat.id)?.id ?? "discover";
|
||||
const projection = projectPreparedAuthoringPhase(beatId);
|
||||
const lifecycleRef = useRef<HTMLElement>(null);
|
||||
|
||||
useLayoutEffect(() => {
|
||||
// The assistant owns its aside markup; decorate that existing boundary here
|
||||
// so the scene can expose hierarchy metadata without widening its API.
|
||||
lifecycleRef.current
|
||||
?.querySelector<HTMLElement>('[aria-label="prepared authoring assistant"]')
|
||||
?.setAttribute("data-visual-role", "support");
|
||||
}, [beatId]);
|
||||
|
||||
return (
|
||||
<>
|
||||
<StageCaption eyebrow="Prepared workflow" title={scene.title}>
|
||||
@@ -58,7 +48,6 @@ export const PreparedAuthoringLifecycleScene = ({ scene, beat, onAdvance }: Prep
|
||||
</StageCaption>
|
||||
<section
|
||||
className="prepared-lifecycle-scene"
|
||||
ref={lifecycleRef}
|
||||
aria-label="prepared workflow authoring lifecycle"
|
||||
data-active-phase={beatId}
|
||||
data-primary-surface="authoring-phase"
|
||||
@@ -67,6 +56,7 @@ export const PreparedAuthoringLifecycleScene = ({ scene, beat, onAdvance }: Prep
|
||||
>
|
||||
<PresentationAssistantPane
|
||||
phase={beatId}
|
||||
visualRole="support"
|
||||
message={projectScene9Message(messageState, beatId)}
|
||||
submittedOverrides={projectScene9SubmittedOverrides(messageState)}
|
||||
runRequested={messageState.runRequested}
|
||||
|
||||
@@ -36,12 +36,23 @@ describe("PresentationAssistantPane", () => {
|
||||
it("renders a persistent prepared replay surface for the current phase", () => {
|
||||
renderPane("validate");
|
||||
|
||||
expect(screen.getByRole("complementary", { name: /prepared authoring assistant/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole("complementary", { name: /prepared authoring assistant/i })).not.toHaveAttribute(
|
||||
"data-visual-role",
|
||||
);
|
||||
expect(screen.getByRole("heading", { name: /authoring assistant/i })).toBeInTheDocument();
|
||||
expect(screen.getByText(/current phase: validate/i)).toBeInTheDocument();
|
||||
expect(screen.getByText(/prepared replay only/i)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("exposes an explicit support role when composed in the lifecycle scene", () => {
|
||||
renderPane("validate", { visualRole: "support" });
|
||||
|
||||
expect(screen.getByRole("complementary", { name: /prepared authoring assistant/i })).toHaveAttribute(
|
||||
"data-visual-role",
|
||||
"support",
|
||||
);
|
||||
});
|
||||
|
||||
it("keeps the active tool group synchronized with the phase", () => {
|
||||
renderPane("artifact");
|
||||
|
||||
|
||||
@@ -10,6 +10,7 @@ import type {
|
||||
|
||||
export type PresentationAssistantPaneProps = {
|
||||
readonly phase: AuthoringPhaseId;
|
||||
readonly visualRole?: "support";
|
||||
readonly message: Scene9MessageProjection;
|
||||
readonly submittedOverrides: Scene9SubmittedOverrides;
|
||||
readonly runRequested: string | null;
|
||||
@@ -33,6 +34,7 @@ const phaseLabels: Readonly<Record<AuthoringPhaseId, string>> = {
|
||||
*/
|
||||
export const PresentationAssistantPane = ({
|
||||
phase,
|
||||
visualRole,
|
||||
message,
|
||||
submittedOverrides,
|
||||
runRequested,
|
||||
@@ -67,6 +69,7 @@ export const PresentationAssistantPane = ({
|
||||
aria-label="prepared authoring assistant"
|
||||
data-phase={phase}
|
||||
data-surface="prepared-replay"
|
||||
data-visual-role={visualRole}
|
||||
>
|
||||
<header className="presentation-assistant-pane__header">
|
||||
<p className="presentation-assistant-pane__eyebrow">Prepared workflow</p>
|
||||
|
||||
@@ -1763,14 +1763,15 @@
|
||||
|
||||
.scene-body__authoring-evidence .authoring-repair__diagnostic,
|
||||
.scene-body__authoring-evidence .authoring-repair__correction {
|
||||
min-height: 8rem;
|
||||
min-height: 0;
|
||||
padding: 1rem;
|
||||
}
|
||||
|
||||
.scene-body__authoring-evidence .authoring-visual--inventory,
|
||||
.scene-body__authoring-evidence .authoring-visual--graph,
|
||||
.scene-body__authoring-evidence .authoring-visual--repair {
|
||||
min-height: 15rem;
|
||||
min-height: 0;
|
||||
height: 100%;
|
||||
}
|
||||
|
||||
.scene-body__authoring-evidence .authoring-visual--graph .authoring-graph__node {
|
||||
@@ -1790,7 +1791,7 @@
|
||||
|
||||
.scene-body__authoring-evidence .authoring-visual--repair[data-authoring-focus="diagnose"] .authoring-repair__diagnostic {
|
||||
grid-column: 1;
|
||||
min-height: 12rem;
|
||||
min-height: 0;
|
||||
}
|
||||
|
||||
.scene-body__authoring-evidence .authoring-visual--repair[data-authoring-focus="repair"] {
|
||||
@@ -1804,7 +1805,7 @@
|
||||
|
||||
.scene-body__authoring-evidence .authoring-visual--repair[data-authoring-focus="repair"] .authoring-repair__correction {
|
||||
grid-column: 1;
|
||||
min-height: 12rem;
|
||||
min-height: 0;
|
||||
}
|
||||
|
||||
.scene-body__authoring-composition .scene-body__authoring-loop {
|
||||
|
||||
Reference in New Issue
Block a user