audit: close review gaps, dedupe control-region and activation helpers

This commit is contained in:
lda
2026-09-04 10:48:29 +07:00 Verified
parent be583661cf
commit 79ce0d3eff
6 changed files with 100 additions and 45 deletions
+2 -4
View File
@@ -170,7 +170,6 @@ def _step_foreach_concurrent(
step=step,
index=index,
activation=activation,
barrier=barrier,
iterable=iterable,
)
@@ -182,7 +181,6 @@ def _step_foreach_concurrent(
step=step,
index=index,
activation=activation,
barrier=barrier,
reducers=reducers,
)
@@ -260,12 +258,12 @@ def _admit_concurrent_children(
step: ForeachNode,
index: WorkflowIndex,
activation: ForeachActivationState,
barrier: ForeachBarrierState,
iterable: list[object],
) -> None:
if step.concurrent is None:
raise WorkflowExecutionError("concurrent foreach requires concurrent policy")
barrier = activation.barrier
loop_start = index.next_node_id(frame.node_id, "loop")
while (
barrier.next_index < len(iterable)
@@ -333,9 +331,9 @@ def _finish_concurrent_foreach(
step: ForeachNode,
index: WorkflowIndex,
activation: ForeachActivationState,
barrier: ForeachBarrierState,
reducers: Mapping[str, ReducerDefinition] | None = None,
) -> RunState:
barrier = activation.barrier
error_records = [
result.error.to_metadata()
for result in sorted(