refactor: move mcp adapter helper to wf_sources_mcp

tests/wf_sources_mcp/test_adapters.py

@@ -0,0 +1,135 @@
+from __future__ import annotations
+
+from dataclasses import dataclass
+from typing import Any
+
+import pytest
+
+from wf_sources_mcp.adapters import require_adapter
+from wf_sources_mcp.auth import AuthRecord
+from wf_sources_mcp.catalog import DiscoveredPrompt, DiscoveredResource, DiscoveredTool
+from wf_sources_mcp.connections import McpSourceConnection
+from wf_sources_mcp.sdk import BackendAdapter, ToolCallResult
+from wf_sources_mcp.transports import StdioSourceTransport
+
+
+class _Adapter:
+    async def list_tools(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+    ) -> list[DiscoveredTool]:
+        return []
+
+    async def list_resources(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+    ) -> list[DiscoveredResource]:
+        return []
+
+    async def list_prompts(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+    ) -> list[DiscoveredPrompt]:
+        return []
+
+    async def get_connection_metadata(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+    ) -> dict[str, Any]:
+        return {}
+
+    async def read_resource(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+        uri: str,
+    ) -> dict[str, Any]:
+        raise NotImplementedError
+
+    async def get_prompt(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+        prompt_name: str,
+        arguments: dict[str, str] | None = None,
+    ) -> dict[str, Any]:
+        raise NotImplementedError
+
+    async def invoke_method(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+        method: str,
+        params: dict[str, Any] | None = None,
+    ) -> dict[str, Any]:
+        raise NotImplementedError
+
+    async def send_notification(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+        method: str,
+        params: dict[str, Any] | None = None,
+    ) -> None:
+        raise NotImplementedError
+
+    async def call_tool(
+        self,
+        connection: McpSourceConnection,
+        auth: AuthRecord | None,
+        tool_name: str,
+        payload: dict[str, Any],
+    ) -> ToolCallResult:
+        raise NotImplementedError
+
+
+@dataclass(slots=True)
+class _LegacyConnection:
+    server: str
+
+
+def test_require_adapter_uses_legacy_server_field() -> None:
+    adapter = _Adapter()
+
+    result = require_adapter(
+        _LegacyConnection(server="demo"),
+        {"demo": adapter},
+    )
+
+    assert result is adapter
+
+
+def test_require_adapter_uses_typed_source_provider_field() -> None:
+    adapter = _Adapter()
+    connection = McpSourceConnection(
+        id="demo.default",
+        provider="demo",
+        account="default",
+        transport=StdioSourceTransport(command="demo-mcp"),
+    )
+
+    result = require_adapter(connection, {"demo": adapter})
+
+    assert result is adapter
+
+
+def test_require_adapter_raises_useful_key_error() -> None:
+    with pytest.raises(KeyError, match="no adapter registered for source 'missing'"):
+        require_adapter(_LegacyConnection(server="missing"), {})
+
+
+def test_require_adapter_has_backend_adapter_static_shape() -> None:
+    adapter: BackendAdapter = _Adapter()
+
+    assert adapter is not None
+
+
+def test_adapter_helper_exports_from_package_root() -> None:
+    from wf_sources_mcp import require_adapter as root_require_adapter
+    from wf_sources_mcp.adapters import require_adapter
+
+    assert root_require_adapter is require_adapter

tests/wf_sources_mcp/test_import_direction_guard.py

@@ -196,3 +196,26 @@ def test_wf_sources_mcp_does_not_import_old_broker_event_modules() -> None:
         "wf_sources_mcp still imports old wf_mcp broker event modules:\n"
         + "\n".join(f"  {violation}" for violation in violations)
     )
+
+
+def test_wf_sources_mcp_does_not_import_old_broker_service_adapter_module() -> None:
+    root = Path(__file__).resolve().parents[2] / "src" / "wf_sources_mcp"
+    forbidden = {"wf_mcp.broker.service.adapters"}
+    violations: list[str] = []
+
+    for py_file in sorted(root.rglob("*.py")):
+        rel = py_file.relative_to(root.parent)
+        module = str(rel.with_suffix("")).replace("/", ".").replace("\\", ".")
+        tree = ast.parse(py_file.read_text(encoding="utf-8"), filename=str(py_file))
+        for node in ast.walk(tree):
+            if isinstance(node, ast.ImportFrom) and node.module in forbidden:
+                violations.append(f"{module}:{node.lineno}: from {node.module} import ...")
+            elif isinstance(node, ast.Import):
+                for alias in node.names:
+                    if alias.name in forbidden:
+                        violations.append(f"{module}:{node.lineno}: import {alias.name}")
+
+    assert violations == [], (
+        "wf_sources_mcp still imports old wf_mcp broker service adapter module:\n"
+        + "\n".join(f"  {violation}" for violation in violations)
+    )