fix: narrow binding validation to not change diagnostic contract for non-platform sources

src/wf_artifacts/validation.py

@@ -29,24 +29,21 @@ def validate_deployment_dependencies(
         else:
             bound_source_id = bindings.get(required.logical_source)
             if bound_source_id is None:
-                if not sources_by_id:
+                diagnostics.append(
-                    bound_source_id = required.logical_source
+                    _diagnostic(
-                else:
+                        code="binding_missing",
-                    diagnostics.append(
+                        logical_ref=logical_ref,
-                        _diagnostic(
+                        required=required,
-                            code="binding_missing",
+                        message=(
-                            logical_ref=logical_ref,
+                            f"No binding exists for logical source "
-                            required=required,
+                            f"{required.logical_source!r}."
-                            message=(
+                        ),
-                                f"No binding exists for logical source "
+                        repair_hint=(
-                                f"{required.logical_source!r}."
+                            "Bind the logical source to a compatible concrete source."
-                            ),
+                        ),
-                            repair_hint=(
-                                "Bind the logical source to a compatible concrete source."
-                            ),
-                        )
                     )
-                    continue
+                )
+                continue
 
         source = sources_by_id.get(bound_source_id)
         if source is None:

tests/artifacts/test_validation.py

@@ -234,7 +234,7 @@ def test_platform_source_requirement_does_not_need_binding() -> None:
     assert diagnostics == []
 
 
-def test_missing_platform_source_still_reports_source_missing() -> None:
+def test_missing_platform_source_still_reports_binding_missing() -> None:
     artifact = artifact_with(
         required_capability(logical_source="wf.std", capability_name="replace")
     )
@@ -251,5 +251,4 @@ def test_missing_platform_source_still_reports_source_missing() -> None:
         sources=[],
     )
 
-    assert [diagnostic.code for diagnostic in diagnostics] == ["source_missing"]
+    assert [diagnostic.code for diagnostic in diagnostics] == ["binding_missing"]
-    assert diagnostics[0].bound_source == "wf.std"