lda.chat/lda-wf
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: narrow binding validation to not change diagnostic contract for non-platform sources

Browse Source
This commit is contained in:
lda
2026-06-13 18:33:04 +07:00 Verified
parent a24f36a80e
commit b6e90c2738
2 changed files with 16 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wf_artifacts/validation.py
+14 -17
View File
@@ -29,24 +29,21 @@ def validate_deployment_dependencies(
else:
bound_source_id = bindings.get(required.logical_source)
if bound_source_id is None:
if not sources_by_id:
bound_source_id = required.logical_source
else:
diagnostics.append(
_diagnostic(
code="binding_missing",
logical_ref=logical_ref,
required=required,
message=(
f"No binding exists for logical source "
f"{required.logical_source!r}."
),
repair_hint=(
"Bind the logical source to a compatible concrete source."
),
)
diagnostics.append(
_diagnostic(
code="binding_missing",
logical_ref=logical_ref,
required=required,
message=(
f"No binding exists for logical source "
f"{required.logical_source!r}."
),
repair_hint=(
"Bind the logical source to a compatible concrete source."
),
)
continue
)
continue
source = sources_by_id.get(bound_source_id)
if source is None:
tests/artifacts/test_validation.py
+2 -3
View File
@@ -234,7 +234,7 @@ def test_platform_source_requirement_does_not_need_binding() -> None:
assert diagnostics == []
def test_missing_platform_source_still_reports_source_missing() -> None:
def test_missing_platform_source_still_reports_binding_missing() -> None:
artifact = artifact_with(
required_capability(logical_source="wf.std", capability_name="replace")
)
@@ -251,5 +251,4 @@ def test_missing_platform_source_still_reports_source_missing() -> None:
sources=[],
)
assert [diagnostic.code for diagnostic in diagnostics] == ["source_missing"]
assert diagnostics[0].bound_source == "wf.std"
assert [diagnostic.code for diagnostic in diagnostics] == ["binding_missing"]