fix: address coderabbit review findings

tests/wf_mcp/service/test_catalog.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import shutil
+from pathlib import Path
 
 from wf_authoring import NodeSpec
 from wf_core import RunStatus
@@ -502,7 +503,7 @@ def test_source_catalog_finds_local_documentation_resource_directly() -> None:
     assert result.uri == test_resource.uri
 
 
-def test_source_catalog_uses_catalog_store_only(tmp_path) -> None:
+def test_source_catalog_uses_catalog_store_only(tmp_path: Path) -> None:
     catalog_store = FileCatalogStore(tmp_path / "catalog")
     service = SourceCatalogService(
         store=catalog_store,

tests/wf_mcp/service/test_upstream_transport.py

@@ -311,7 +311,9 @@ async def test_upstream_transport_live_diagnostics_report_missing_auth_ref(
     assert "github.creds" in diagnostics[0].message
 
 
-def test_upstream_transport_uses_separate_auth_and_catalog_stores(tmp_path) -> None:
+def test_upstream_transport_uses_separate_auth_and_catalog_stores(
+    tmp_path: Path,
+) -> None:
     auth_store = FileAuthStore(tmp_path / "auth")
     catalog_store = FileCatalogStore(tmp_path / "catalog")
     events = []

tests/wf_mcp/test_auth.py

@@ -157,7 +157,7 @@ def test_connection_auth_diagnostic_reports_missing_auth_ref() -> None:
 
     diagnostic = connection_auth_diagnostic(
         connection,
-        load_auth=lambda auth_ref: None,
+        load_auth_ref=lambda auth_ref: None,
         logical_ref="github",
     )
 
@@ -188,7 +188,7 @@ def test_connection_auth_diagnostic_ignores_absent_or_present_auth_ref() -> None
     assert (
         connection_auth_diagnostic(
             no_ref,
-            load_auth=lambda auth_ref: None,
+            load_auth_ref=lambda auth_ref: None,
             logical_ref="github",
         )
         is None
@@ -196,7 +196,7 @@ def test_connection_auth_diagnostic_ignores_absent_or_present_auth_ref() -> None
     assert (
         connection_auth_diagnostic(
             with_ref,
-            load_auth=lambda auth_ref: auth,
+            load_auth_ref=lambda auth_ref: auth,
             logical_ref="github",
         )
         is None