test: cover interrupt resume schema validation

This commit is contained in:
lda
2026-07-01 06:00:06 +07:00 Verified
parent 00ea4daa5e
commit e7099b330a
3 changed files with 118 additions and 2 deletions
+11 -2
View File
@@ -159,11 +159,17 @@ def resume_run(
run_id: Annotated[str, typer.Argument(help="Interrupted durable run id.")], run_id: Annotated[str, typer.Argument(help="Interrupted durable run id.")],
payload_json: Annotated[ payload_json: Annotated[
str | None, str | None,
typer.Option("--payload", help="Resume payload JSON object."), typer.Option(
"--payload",
help="Resume payload JSON object; interrupted runs may validate it against their resume schema.",
),
] = None, ] = None,
payload_file: Annotated[ payload_file: Annotated[
Path | None, Path | None,
typer.Option("--payload-file", help="Path to resume payload JSON object."), typer.Option(
"--payload-file",
help="Path to resume payload JSON object; schema validation happens before state mutation.",
),
] = None, ] = None,
outcome: Annotated[ outcome: Annotated[
str, str,
@@ -184,6 +190,9 @@ def resume_run(
The target store owns the paused run. With `--local`, this is the local file The target store owns the paused run. With `--local`, this is the local file
store; with `--url`, this is the long-lived JSON-RPC server's store. store; with `--url`, this is the long-lived JSON-RPC server's store.
The interrupted run may expose a resume schema through `wf run inspect`.
Invalid resume payloads are rejected before workflow state is mutated.
""" """
try: try:
resume_payload = parse_json_input( resume_payload = parse_json_input(
+99
View File
@@ -17,6 +17,7 @@ from wf_api.runs import WorkflowRunApi
from wf_artifacts import ( from wf_artifacts import (
FileRunStore, FileRunStore,
FileWorkflowArtifactStore, FileWorkflowArtifactStore,
WorkflowArtifact,
WorkflowDeployment, WorkflowDeployment,
) )
from wf_mcp.broker import WfMcpService from wf_mcp.broker import WfMcpService
@@ -379,3 +380,101 @@ async def test_workflow_api_facade_lists_runs(tmp_path: Path) -> None:
assert payload["total"] == 1 assert payload["total"] == 1
assert payload["runs"][0]["deployment_id"] == "echo.personal" assert payload["runs"][0]["deployment_id"] == "echo.personal"
def _interrupt_artifact_with_resume_schema() -> WorkflowArtifact:
return WorkflowArtifact(
id="approval",
version=1,
title="Approval",
input_schema={
"type": "object",
"properties": {"message": {"type": "string"}},
"required": ["message"],
},
output_schema={"type": "object", "properties": {}},
outcomes=("submitted",),
plan={
"name": "approval",
"input_schema": {
"type": "object",
"properties": {"message": {"type": "string"}},
"required": ["message"],
},
"state_schema": {"fields": {}},
"output_schema": {"type": "object", "properties": {}},
"outcomes": ["submitted"],
"start": "approval",
"nodes": [
{
"id": "approval",
"type": "interrupt",
"kind": "approval",
"request": [
{
"path": {"root": "input", "parts": ["message"]},
"target": {"root": "local", "parts": ["message"]},
}
],
"resume": [],
"outcomes": ["submitted"],
"resume_schema": {
"type": "object",
"properties": {"approved": {"type": "boolean"}},
"required": ["approved"],
"additionalProperties": False,
},
},
{"id": "end_submitted", "type": "end", "outcome": "submitted"},
],
"edges": [
{"from": "approval", "outcome": "submitted", "to": "end_submitted"}
],
},
)
def _seed_interrupt_deployment_with_resume_schema(
root: Path,
) -> tuple[WfMcpService, str]:
artifact_store = FileWorkflowArtifactStore(root)
artifact_store.save_artifact(_interrupt_artifact_with_resume_schema())
artifact_store.save_deployment(
WorkflowDeployment(
id="approval.default",
artifact_id="approval",
artifact_version=1,
bindings=[],
)
)
service = WfMcpService(
store=FileStore(root / "mcp"),
artifact_store=artifact_store,
run_store=FileRunStore(root / "mcp"),
)
return service, "approval.default"
async def test_resume_run_rejects_payload_that_violates_interrupt_schema(
tmp_path: Path,
) -> None:
root = tmp_path / "run_api_resume_schema_validation"
service, deployment_id = _seed_interrupt_deployment_with_resume_schema(root)
context = context_from_service(service)
api = WorkflowRunApi(context)
started = await api.run_deployment(
deployment_id=deployment_id,
workflow_input={"message": "approve?"},
)
run_id = started["run_id"]
assert run_id is not None
resumed = await api.resume_run(
run_id=run_id,
resume_payload={"approved": "yes"},
resume_outcome="submitted",
)
assert resumed["status"] == "failed"
assert "interrupt resume for approval" in resumed["error"]
+8
View File
@@ -258,6 +258,14 @@ def test_wf_draft_route_flags_reject_duplicate_outcomes() -> None:
assert "duplicate --route for 'ok'" in branch_result.output assert "duplicate --route for 'ok'" in branch_result.output
def test_wf_run_resume_help_exists() -> None:
result = runner.invoke(app, ["run", "resume", "--help"])
assert result.exit_code == 0
assert "resume payload" in result.output.lower()
assert "schema" in result.output.lower()
def test_wf_draft_set_input_rejects_local_prefixed_target() -> None: def test_wf_draft_set_input_rejects_local_prefixed_target() -> None:
result = runner.invoke( result = runner.invoke(
app, app,