remove these mf AGAIN
This commit is contained in:
@@ -1,72 +0,0 @@
|
||||
# Task 1 Implementation Report
|
||||
|
||||
## Scope
|
||||
|
||||
Implemented the canonical defense rehearsal route manifest and documentation
|
||||
from `task-1-brief.md`.
|
||||
|
||||
- Added `scripts/presentation-rehearsal-routes.json` with all 42 current
|
||||
`mainScenes` scene/beat pairs. Each object has exactly `sceneId`, `beatId`,
|
||||
`route`, and `fileStem`.
|
||||
- Added `docs/runbooks/presentation-rehearsal-matrix.md` with one row per route,
|
||||
including the presenter sentence, dominant/supporting visuals, chat mode,
|
||||
evidence mode, and exact fallback route.
|
||||
- Linked the matrix from `docs/runbooks/defense-presentation.md` and explicitly
|
||||
described it as a rehearsal checklist rather than a new story or product
|
||||
contract.
|
||||
- Extended `storyboard-navigation.test.ts` to validate unique and complete
|
||||
bidirectional coverage against `mainScenes`, exact manifest keys, canonical
|
||||
route fields, and hash round-trips through `hashForLocation` and
|
||||
`locationFromHash`.
|
||||
|
||||
## Verification
|
||||
|
||||
The test-first check was performed before creating the manifest: the focused
|
||||
Vitest suite failed with an import-resolution error because
|
||||
`scripts/presentation-rehearsal-routes.json` did not exist. After adding the
|
||||
manifest, the same suite passed.
|
||||
|
||||
Exact verification commands and results:
|
||||
|
||||
```text
|
||||
pnpm --dir web/apps/console test -- src/presentation/storyboard-navigation.test.ts
|
||||
PASS: 1 test file, 11 tests
|
||||
|
||||
pnpm --dir web/apps/console typecheck
|
||||
PASS: tsc -b --pretty false
|
||||
|
||||
PowerShell JSON validation using ConvertFrom-Json
|
||||
PASS: manifest entries: 42
|
||||
PASS: manifest keys: beatId, fileStem, route, sceneId
|
||||
|
||||
PowerShell matrix row count
|
||||
PASS: matrix route rows: 42
|
||||
|
||||
git diff --check
|
||||
PASS: no whitespace errors; Git reported only LF-to-CRLF normalization warnings
|
||||
```
|
||||
|
||||
## Self-Review
|
||||
|
||||
- The manifest uses the current `mainScenes` IDs, including `approval`,
|
||||
`resume-output-evidence`, and `conclusion/questions`; no historical
|
||||
interrupt-evidence or workflow-demo route names were introduced.
|
||||
- The coverage test fails on a missing beat with its scene ID and rejects stale
|
||||
manifest entries, duplicate pairs, incorrect canonical route strings, and
|
||||
malformed navigation round-trips.
|
||||
- Matrix evidence references remain bounded by existing storyboard pointers,
|
||||
prepared replay evidence, and the defense runbook fallback wording. No
|
||||
expected output was invented.
|
||||
- All current scene beats use `hidden` chat mode in the storyboard metadata, so
|
||||
the matrix records `hidden` consistently rather than inventing full, rail, or
|
||||
dock modes.
|
||||
|
||||
## Deviations And Concerns
|
||||
|
||||
No functional deviations from the brief. The repository emits line-ending
|
||||
normalization warnings for the touched text files during Git operations; these
|
||||
are not whitespace errors and do not affect the committed content.
|
||||
|
||||
## Commit
|
||||
|
||||
Implementation commit: `fce33934` (`docs: define presentation rehearsal route matrix`)
|
||||
@@ -1,31 +0,0 @@
|
||||
# Task 2 Implementation Report
|
||||
|
||||
## Scope
|
||||
|
||||
Implemented the repeatable screenshot runner for the Task 1 rehearsal manifest.
|
||||
|
||||
- Added `scripts/presentation-rehearsal.ps1` with configurable base URL, output root, and viewports.
|
||||
- The runner loads `scripts/presentation-rehearsal-routes.json`, validates the manifest is present/non-empty, captures every route at `1280,720` and `1024,768`, waits 800 ms, and fails with startup/capture errors.
|
||||
- Added the rehearsal output directory to `.gitignore`.
|
||||
- Documented the runner in `docs/runbooks/presentation-visual-review.md`.
|
||||
|
||||
## Verification
|
||||
|
||||
```text
|
||||
pwsh -File scripts/presentation-rehearsal.ps1
|
||||
PASS: 42 routes x 2 viewports = 84 screenshots captured
|
||||
git diff --check
|
||||
PASS: no whitespace errors; only line-ending normalization warnings
|
||||
```
|
||||
|
||||
The user’s presentation dev server was already running. No server was stopped
|
||||
or restarted.
|
||||
|
||||
## Commit
|
||||
|
||||
Implementation commit: `3770e345` (`test: add repeatable presentation screenshot rehearsal`)
|
||||
|
||||
## Concerns
|
||||
|
||||
The script captures screenshots but does not perform DOM geometry assertions;
|
||||
those remain in the route/browser review and later rehearsal tasks as planned.
|
||||
@@ -1,33 +0,0 @@
|
||||
# Task 3 Report
|
||||
|
||||
## Changed Files
|
||||
|
||||
- `web/apps/console/src/presentation/presentation-rehearsal.test.ts`
|
||||
- Added an exact set comparison between `mainScenes` and the expected 14 scene IDs.
|
||||
- Verifies expected beat counts and canonical beat IDs for every scene.
|
||||
- Failure messages identify the missing scene or `scene/beat` pair.
|
||||
- `web/apps/console/src/presentation/PresentationRoute.test.tsx`
|
||||
- Added direct-hash coverage for the ten intended representative routes, including Scene 8 (`#scene/agent-handoff/request`).
|
||||
- Verifies visible accessible headings and demo-chrome ownership for Scenes 8 through 12.
|
||||
- Uses the presentation footer's accessible action/status surfaces instead of `data-testid` for demo-chrome ownership.
|
||||
- Added no-accidental-chrome coverage for title, problem, architecture, evaluation, and conclusion routes.
|
||||
- Verifies prepared lifecycle assistant-pane ownership, footer ownership, and exactly one run action.
|
||||
|
||||
## Deviations
|
||||
|
||||
- `#scene/conclusion/questions` intentionally asserts the visible `Thesis contribution` discussion-index heading. That beat renders the examiner discussion index instead of the `Limits and Conclusion` scene caption.
|
||||
- The typed approval route intentionally checks for the visible demo rail rather than a run button because its chrome is a paused review status with a `Submit` action.
|
||||
|
||||
## Bugs
|
||||
|
||||
- No production bugs found. No production files were changed.
|
||||
|
||||
## Verification
|
||||
|
||||
- `pnpm --dir web/apps/console test -- src/presentation/presentation-rehearsal.test.ts src/presentation/PresentationRoute.test.tsx`
|
||||
- Passed: 2 test files, 68 tests.
|
||||
- `pnpm --dir web/apps/console typecheck`
|
||||
- Passed: `tsc -b --pretty false`.
|
||||
- `git diff --check`
|
||||
- Passed with no whitespace errors.
|
||||
- Self-review confirmed the changes are limited to the Task 3 test contracts and this report.
|
||||
@@ -1,52 +0,0 @@
|
||||
# Task 6 Report
|
||||
|
||||
## Scope
|
||||
|
||||
Completed the final presentation demo chrome integration task without changing
|
||||
production APIs or adding product behavior.
|
||||
|
||||
- Added route-level regressions for Scene 8 -> Scene 10 operation -> Scene 10
|
||||
graph -> title backtracking, stale launch/replay chrome, and approval paused
|
||||
label removal after submit.
|
||||
- Added CSS contract assertions for compact footer rail sizing and removal of
|
||||
`.demo-run-launch-control`.
|
||||
- Updated `web/README.md` to document the Scenes 8-12 footer rail and removed
|
||||
stale Scene 8 probing and Scene 10 in-scene launch claims.
|
||||
- Marked Scene 10 factual graph/proof work complete in the roadmap, linked the
|
||||
design and implementation plan, and kept file-preview work deferred.
|
||||
- Moved the completed Scene 10 plan to `docs/historical/superpowers/plans/`.
|
||||
|
||||
## Verification
|
||||
|
||||
- Focused route/CSS tests: passed, 2 files, 63 tests.
|
||||
- Full web test gate: passed, 91 files, 715 tests.
|
||||
- Web typecheck: passed for console, RPC package, and server.
|
||||
- Web build: passed. Vite emitted the existing chunk-size warning for the main
|
||||
bundle; no build failure occurred.
|
||||
- `git diff --check`: passed.
|
||||
|
||||
Screenshots were captured at 1280x720 after 2-second waits using the existing
|
||||
running server and Playwright tooling. Files were written outside the
|
||||
repository under `%TEMP%`:
|
||||
|
||||
- `task-6-title.png`
|
||||
- `task-6-scene-8.png`
|
||||
- `task-6-operation.png`
|
||||
- `task-6-approval.png`
|
||||
- `task-6-output.png`
|
||||
|
||||
## Review
|
||||
|
||||
Two-axis repository review against `46f25b45`:
|
||||
|
||||
- Standards axis: no findings.
|
||||
- Spec axis: no missing requirements, scope creep, or incorrect Task 6
|
||||
implementation findings.
|
||||
|
||||
## Deviations And Concerns
|
||||
|
||||
- The first parallel full-gate invocation showed two existing route-test
|
||||
failures caused by cross-file Vitest interference. The required rerun with
|
||||
servers unchanged passed completely.
|
||||
- Browser console output contained one `favicon.ico` 404 from the existing dev
|
||||
server. No presentation route error was observed.
|
||||
Reference in New Issue
Block a user